Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: record visit per day #224

Merged
merged 9 commits into from
May 25, 2023
Merged

feat: record visit per day #224

merged 9 commits into from
May 25, 2023

Conversation

huai-jie
Copy link
Contributor

No description provided.

iuioiua
iuioiua suggested changes May 24, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! I suggest just a few tweaks. Also, could you please create a simple getVisitsPerDay(date: string): Promise<bigint> (or similar) and add a test for both?

utils/db.ts Outdated Show resolved Hide resolved
utils/db.ts Outdated Show resolved Hide resolved
utils/db.ts Outdated Show resolved Hide resolved
utils/db.ts Outdated Show resolved Hide resolved
@huai-jie huai-jie marked this pull request as draft May 24, 2023 08:04
@huai-jie huai-jie marked this pull request as ready for review May 24, 2023 17:49
iuioiua
iuioiua suggested changes May 25, 2023
View reviewed changes
utils/db.ts Outdated Show resolved Hide resolved
utils/db_test.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify my previous point, I referred to a different Deno.test() within the same file. Either way, all good. I made the change 😄

Thanks for your great work again, @huai-jie.

@iuioiua iuioiua merged commit f96d984 into denoland:main May 25, 2023
@iuioiua iuioiua mentioned this pull request May 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huai-jie @iuioiua