-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add reference to unstable types #279
Conversation
As Deno KV is still unstable, its types are not included in `deno.ns`. This means that when opening the project in VS Code, it does not recognise functions such as `Deno.openKv()`. Thus, by referencing `deno.unstable` we also include these types.
Thanks, @smitssjors. I don't see the same issue in my VS Code. Can you share exactly where you're seeing this? |
I freshly cloned the project and it is actually not showing up now but I am not sure why. I first ran into this issue when creating a new fresh project. I figured as SaaSKit also uses KV it had some configuration which fixes it but upon cloning I ran into the same issue. After some looking around I did not find any relevant configuration differences as far as I know. I also just created a new fresh project and the issue is still there. This might be some weird stuff with VS and/or the plugin and/or deno lsp so im not sure where to look but adding the reference to the fresh project did fix it.
deno 1.34.3 (release, x86_64-apple-darwin)
v8 11.5.150.2
typescript 5.0.4 VS Code
Deno VS Code plugin version 3.19.1 |
How about we instead add |
I checked in a new GitHub Codespace and the issue exists there too. As this is not the place to discuss or fix it I'll close the PR and open an issue in the repo for the extension. You can set |
Actually, you were right. Let's add this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
As Deno KV is still unstable, its types are not included in
deno.ns
. This means that when opening the project in VS Code, it does not recognise functions such asDeno.openKv()
(regardless whether the"deno.unstable": true
VS Code option is set). By referencingdeno.unstable
we also include these types.