Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup twind-related functionality #282

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jun 22, 2023

Everything appears fine after the changes.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jun 22, 2023

@lino-levan, looks like presetAutoprefix() may not be needed (ref: https://fresh.deno.dev/docs/examples/using-twind-v1).

@iuioiua iuioiua merged commit b27cfbe into main Jun 22, 2023
@iuioiua iuioiua deleted the twind-cleanup branch June 22, 2023 04:02
@lino-levan
Copy link
Contributor

presetAutoprefix() as its name implies is useful for targeting features that still have prefixes. Definitely a few sharp corners if you choose not to use it (especially around webkit) that I've personally encountered. It isn't strictly necessary but I'd still support having it on by default for beginners.

@lino-levan
Copy link
Contributor

To follow up on the comment, I wanted to check that I wasn't going insane, but no there are definitely some tailwind features that need auto-prefixing.

This is one of the sites I helped build (with fresh) in Safari
image

This is how it renders in chrome without the autoprefix
image

This is how it renders in chrome with autoprefix
image

@iuioiua
Copy link
Contributor Author

iuioiua commented Jun 22, 2023

Oh, interesting... I should add a note where presetAutoprefix() was that states this fact. Thanks!

@lino-levan
Copy link
Contributor

Definitely one of those bugs that are hard to locate. A note for future maintainers would be really nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants