tests(db): test compareScore() and getAreVotedBySessionId()
#300
Conversation
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
| assertEquals(compareScore(item1, item2), 1); | ||
| }); | ||
|
|
||
| Deno.test("[db] getAreVotedBySessionId()", async () => { |
There was a problem hiding this comment.
Can you please add cases for when sessionId and sessionUser are falsy?
There was a problem hiding this comment.
Check the commit 19e3e33 if this is what you thought :)
There was a problem hiding this comment.
Or wait you'll probably mean something like
assertArrayIncludes(await getAreVotedBySessionId([item], null), []);
Do you?
There was a problem hiding this comment.
More like:
assertEquals(await getAreVotedBySessionId([item], undefined), []);There was a problem hiding this comment.
Got you. That example came to my mind just before I opened this PR 😄
There was a problem hiding this comment.
What do you prefer assertEquals or assertArrayIncludes in this case?
There was a problem hiding this comment.
assertEquals will do the trick.
| @@ -205,3 +208,49 @@ Deno.test("[db] createComment() + getCommentsByItem()", async () => { | |||
| await assertRejects(async () => await createComment(comment2)); | |||
| assertArrayIncludes(await getCommentsByItem(itemId), [comment1, comment2]); | |||
| }); | |||
|
|
|||
| Deno.test("[db] compareScore()", () => { | |||
There was a problem hiding this comment.
Another way we could do this is to create an items array in the wrong order by score, then sort it via compareScore() and check the new order. This doesn't improve anything in a technical sense but does convey the intent and behaviour of the use of compareScore() to the reader. WDYT?
There was a problem hiding this comment.
Yes, that sounds like a good idea! Will implement it towards the end of the week :)
There was a problem hiding this comment.
Updated it in 153f423. This is way better than before. I also added a third item to not just switch the items from left to right.
iuioiua
changed the title
compareScore() and getAreVotedBySessionId()
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
|
Interesting that the tests are failing on Linux. Is there something I can do about it? |
|
The failure on Linux is due to an endpoint error when downloading imports. Unfortunately, it happens occasionally. |
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
This should help a little with #267