Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: redesign submit page #395

Merged
merged 3 commits into from
Jul 24, 2023
Merged

refactor: redesign submit page #395

merged 3 commits into from
Jul 24, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 24, 2023

Hash: I feel like this is missing something, but I don't know what. Any ideas, or do you think it's good?
Andy: I included minimal copy, which looks sufficient to me.

Before:
image

After:
image

@iuioiua iuioiua requested review from lambtron and hashrock July 24, 2023 08:40
@hashrock
Copy link
Contributor

hashrock commented Jul 24, 2023

let me do some tweaks. please feel free to revert some changes you don't want.

  • Limited content width. If white space is conspicuous, it may look better if max-width is specified.
  • Wider margins throughout.
  • Added labels to text fields. For accessibility, placeholder attributes should not be used in place of labels.
  • It looked a little odd that the text in the button was left aligned, so I centered it.

Preview:

image

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 24, 2023

Looks amazing! Thanks @hashrock!

@iuioiua iuioiua merged commit 4985a53 into main Jul 24, 2023
@iuioiua iuioiua deleted the redesign-submit-page branch July 24, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants