Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: users table #396

Merged
merged 4 commits into from
Jul 27, 2023
Merged

feat: users table #396

merged 4 commits into from
Jul 27, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 26, 2023 •
edited
Loading

This change also:

  • Makes the site text size slightly smaller. Previously, it seemed too big.
  • Adds a <TabsBar /> component.

Closes #370

localhost_8000_dashboard_users (2)

@iuioiua iuioiua requested review from lambtron and hashrock July 26, 2023 07:46
@iuioiua iuioiua marked this pull request as ready for review July 26, 2023 07:47
@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 26, 2023

@hashrock, I want to remove the "Avatar" column header text (empty <th>). However, when I do so, the entire avatar column disappears on smaller screens.

Also, I'd like the avatar column to tightly fit the avatar images. Right now, it's wider than it needs to be.

hashrock
hashrock approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@hashrock hashrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 27, 2023

@hashrock, would you happen to have any suggestions regarding my previous comment?

@hashrock
Copy link
Contributor

hashrock commented Jul 27, 2023 •
edited
Loading

@iuioiua hmm I'm not familiar with table styling, so I'm not sure how to solve it.

just a workaround, but how about combine these columns?

image

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 27, 2023

@iuioiua hmm I'm not familiar with table styling, so I'm not sure how to solve it.

just a workaround, but how about combine these columns?

image

Done!

@iuioiua iuioiua merged commit a01cb2a into main Jul 27, 2023
@iuioiua iuioiua deleted the users-table branch July 27, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashrock hashrock hashrock approved these changes

@lambtron lambtron Awaiting requested review from lambtron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: add simple users table under charts in admin dashboard
2 participants
@iuioiua @hashrock