Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove: assertIsEntry() #477

Merged
merged 2 commits into from
Sep 2, 2023
Merged

remove: assertIsEntry() #477

merged 2 commits into from
Sep 2, 2023

Conversation

gaurab-khanal
Copy link
Contributor

No description provided.

@iuioiua
Copy link
Contributor

iuioiua commented Sep 1, 2023

Please run deno fmt to format then Deno task ok to check everything else is fine?

@iuioiua iuioiua changed the title Removed ssertIsEntry() as it was not used anywhere in codebase remove: assertIsEntry() Sep 1, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Sep 1, 2023

Closes #465

@gaurab-khanal
Copy link
Contributor Author

Please run deno fmt to format then Deno task ok to check everything else is fine?
When I ran the above command I got these errors:

(no-unused-vars) `assertNotEquals` is never used
import { assertNotEquals } from "std/testing/asserts.ts";

Should I remove that import line and make PR again?

@iuioiua
Copy link
Contributor

iuioiua commented Sep 2, 2023

Yes, please remove that line. No need to create another PR. Please just update this one.

@gaurab-khanal
Copy link
Contributor Author

Yes, please remove that line. No need to create another PR. Please just update this one.

Just made the changes you mentioned.

iuioiua
iuioiua approved these changes Sep 2, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM! Thank you for your contribution. Much appreciated!

@iuioiua iuioiua merged commit 5580e4e into denoland:main Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaurab-khanal @iuioiua