fix: avoid showing "No items found" stats in <ItemsList />
#559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuioiua
reviewed
Sep 10, 2023
islands/ItemsList.tsx
Outdated
Comment on lines
80
to
93
| {isLoadingSig.value !== undefined && !isLoadingSig.value | ||
| ? itemsSig.value.length > 0 | ||
| ? itemsSig.value.map((item, id) => { | ||
| return ( | ||
| <ItemSummary | ||
| key={item.id} | ||
| item={item} | ||
| isVoted={itemsAreVotedSig.value[id]} | ||
| isSignedIn={props.isSignedIn} | ||
| /> | ||
| ); | ||
| }) | ||
| : <EmptyItemsList /> | ||
| : "█"} |
There was a problem hiding this comment.
Can you make this a little more readable, please? I think we should avoid nesting ternary operators.
iuioiua
changed the title
<ItemsList />
|
@iuioiua man! how right you were. This reads way better. |
|
After seeing this PR I cannot help but wonder what was I doing this whole time? 🤔 |
iuioiua
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #472
@iuioiua this is as simple as I got, without being too intrusive; I personally like it; the problem was a bug regarding the state change of the variable
isLoadingSig, I was able to avoid it by initializing the variable asundefinedand bypassing it with the conditional rendering not sure if is worth taking another look at it some other time.Note: The simplicity of this PR does not reflect at all the time that took me to get there — just for the record.