Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: meta tag component #66

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Conversation

niklasmtj
Copy link
Contributor

This fixes #55.

I added the newly created Meta component also to the Head component which is already used on a couple of pages.

Happy to about any feedback about the component.

Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, except for a couple of things. Can you also add somewhere in the README that these meta tags are a feature? A single line should do.

Note: we'll have to validate these meta tags once this PR is pushed to the public website.

components/Meta.tsx Outdated Show resolved Hide resolved
components/Meta.tsx Outdated Show resolved Hide resolved
components/Meta.tsx Outdated Show resolved Hide resolved
Signed-off-by: Niklas Metje <22395665+niklasmtj@users.noreply.github.com>
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! Thank you, @niklasmtj.

@iuioiua iuioiua merged commit 88c2c62 into denoland:main Apr 14, 2023
@niklasmtj niklasmtj deleted the feat/meta-tag-component branch April 14, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: <Meta /> component
2 participants