feat: deno task init:stripe and further documentation improvements
#93
Conversation
What do you suggest?
It was deliberately written to replace instructions with automatic setup. Why would that be? |
|
|
||
| async function createPremiumTierProduct(stripe: Stripe) { | ||
| return await stripe.products.create({ | ||
| name: "Premium tier", |
There was a problem hiding this comment.
I'm wondering if the stuff in this object should be configurable? Does that make any sense?
There was a problem hiding this comment.
Good suggestion. Though, we'll leave this as-is for now in the spirit of prioritising ease of setup over customizability. Either way, I've improved the comment.
|
That seems good enough for now. LGTM |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
README.md
Outdated
| [your Stripe dashboard settings](https://dashboard.stripe.com/test/apikeys) | ||
| to copy the `STRIPE_SECRET_KEY` into your `.env` file. We recommend using the | ||
| test key for your development environment. | ||
| > Note: go to [init/stripe.ts] if you'd like to learn more about how the |
There was a problem hiding this comment.
@niklasmtj, regarding #93 (comment), I'd rather have one or the other. I've added this comment to point people in the right direction if they want to learn more. At some point, I'll include technical details as JSDoc comments in the implementation to give an even more precise idea of what's happening. Do you think this addresses your concern?
iuioiua
changed the title
deno task init:stripedeno task init:stripe and further documentation improvements
|
I just tested this locally, and it works! 🥳 |
Previously, a bit of manual work was required to set up Stripe. This change adds the init:stripe task, which:
This dramatically reduces the time and steps needed and the chance of errors in setting up Stripe.
Contributors, please feel free to test and provide feedback.