refactor(http): prepare for noUncheckedIndexedAccess

http/_negotiation/encoding.ts

@@ -53,7 +53,7 @@ function parseEncoding(
     for (const param of params) {
       const p = param.trim().split("=");
       if (p[0] === "q") {
-        q = parseFloat(p[1]);
+        q = parseFloat(p[1]!);
         break;
       }
     }
@@ -92,7 +92,7 @@ function parseAcceptEncoding(accept: string): EncodingSpecificity[] {
   let minQuality = 1;
 
   for (let i = 0; i < accepts.length; i++) {
-    const encoding = parseEncoding(accepts[i].trim(), i);
+    const encoding = parseEncoding(accepts[i]!.trim(), i);
 
     if (encoding) {
       parsedAccepts.push(encoding);
@@ -158,5 +158,5 @@ export function preferredEncodings(
   return priorities
     .filter(isQuality)
     .sort(compareSpecs)
-    .map((priority) => provided[priorities.indexOf(priority)]);
+    .map((priority) => provided[priorities.indexOf(priority)]!);
 }

http/_negotiation/language.ts

@@ -48,7 +48,8 @@ function parseLanguage(
     return undefined;
   }
 
-  const [, prefix, suffix] = match;
+  const prefix = match.at(-2)!;
+  const suffix = match.at(-1)!;
   const full = suffix ? `${prefix}-${suffix}` : prefix;
 
   let q = 1;
@@ -57,7 +58,7 @@ function parseLanguage(
     for (const param of params) {
       const [key, value] = param.trim().split("=");
       if (key === "q") {
-        q = parseFloat(value);
+        q = parseFloat(value!);
         break;
       }
     }
@@ -71,7 +72,7 @@ function parseAcceptLanguage(accept: string): LanguageSpecificity[] {
   const result: LanguageSpecificity[] = [];
 
   for (let i = 0; i < accepts.length; i++) {
-    const language = parseLanguage(accepts[i].trim(), i);
+    const language = parseLanguage(accepts[i]!.trim(), i);
     if (language) {
       result.push(language);
     }
@@ -140,5 +141,5 @@ export function preferredLanguages(
   return priorities
     .filter(isQuality)
     .sort(compareSpecs)
-    .map((priority) => provided[priorities.indexOf(priority)]);
+    .map((priority) => provided[priorities.indexOf(priority)]!);
 }

http/_negotiation/media_type.ts

@@ -56,8 +56,8 @@ function splitMediaTypes(accept: string): string[] {
 
   let j = 0;
   for (let i = 1; i < accepts.length; i++) {
-    if (quoteCount(accepts[j]) % 2 === 0) {
-      accepts[++j] = accepts[i];
+    if (quoteCount(accepts[j]!) % 2 === 0) {
+      accepts[++j] = accepts[i]!;
     } else {
       accepts[j] += `,${accepts[i]}`;
     }
@@ -73,8 +73,8 @@ function splitParameters(str: string): string[] {
 
   let j = 0;
   for (let i = 1; i < parameters.length; i++) {
-    if (quoteCount(parameters[j]) % 2 === 0) {
-      parameters[++j] = parameters[i];
+    if (quoteCount(parameters[j]!) % 2 === 0) {
+      parameters[++j] = parameters[i]!;
     } else {
       parameters[j] += `;${parameters[i]}`;
     }
@@ -87,7 +87,7 @@ function splitParameters(str: string): string[] {
 
 function splitKeyValuePair(str: string): [string, string | undefined] {
   const [key, value] = str.split("=");
-  return [key.toLowerCase(), value];
+  return [key!.toLowerCase(), value];
 }
 
 function parseMediaType(
@@ -102,7 +102,9 @@ function parseMediaType(
 
   const params: { [param: string]: string | undefined } = Object.create(null);
   let q = 1;
-  const [, type, subtype, parameters] = match;
+  const type = match.at(-3)!;
+  const subtype = match.at(-2)!;
+  const parameters = match.at(-1)!;
 
   if (parameters) {
     const kvps = splitParameters(parameters).map(splitKeyValuePair);
@@ -129,7 +131,7 @@ function parseAccept(accept: string): MediaTypeSpecificity[] {
 
   const mediaTypes: MediaTypeSpecificity[] = [];
   for (let i = 0; i < accepts.length; i++) {
-    const mediaType = parseMediaType(accepts[i].trim(), i);
+    const mediaType = parseMediaType(accepts[i]!.trim(), i);
 
     if (mediaType) {
       mediaTypes.push(mediaType);
@@ -233,5 +235,5 @@ export function preferredMediaTypes(
   return priorities
     .filter(isQuality)
     .sort(compareSpecs)
-    .map((priority) => provided[priorities.indexOf(priority)]);
+    .map((priority) => provided[priorities.indexOf(priority)]!);
 }

http/cookie.ts

@@ -296,14 +296,14 @@ function parseSetCookie(value: string): Cookie | null {
       return [key, values.join("=")];
     });
   const cookie: Cookie = {
-    name: attrs[0][0],
-    value: attrs[0][1],
+    name: attrs[0]![0]!,
+    value: attrs[0]![1]!,
   };
 
   for (const [key, value] of attrs.slice(1)) {
-    switch (key.toLocaleLowerCase()) {
+    switch (key!.toLocaleLowerCase()) {
       case "expires":
-        cookie.expires = new Date(value);
+        cookie.expires = new Date(value as string);
         break;
       case "max-age":
         cookie.maxAge = Number(value);

http/file_server.ts

@@ -636,7 +636,7 @@ export async function serveDir(
   if (opts.headers && !isRedirectResponse) {
     for (const header of opts.headers) {
       const headerSplit = header.split(":");
-      const name = headerSplit[0];
+      const name = headerSplit[0]!;
       const value = headerSplit.slice(1).join(":");
       response.headers.append(name, value);
     }

http/server_test.ts

@@ -155,7 +155,7 @@ Deno.test(
 
     try {
       assertEquals(server.addrs.length, 3);
-      assertEquals(server.addrs[0].transport, "tcp");
+      assertEquals(server.addrs[0]!.transport, "tcp");
       assertEquals(
         (server.addrs[0] as Deno.NetAddr).hostname,
         listenerOneOptions.hostname,
@@ -164,7 +164,7 @@ Deno.test(
         (server.addrs[0] as Deno.NetAddr).port,
         listenerOneOptions.port,
       );
-      assertEquals(server.addrs[1].transport, "tcp");
+      assertEquals(server.addrs[1]!.transport, "tcp");
       assertEquals(
         (server.addrs[1] as Deno.NetAddr).hostname,
         listenerTwoOptions.hostname,
@@ -173,7 +173,7 @@ Deno.test(
         (server.addrs[1] as Deno.NetAddr).port,
         listenerTwoOptions.port,
       );
-      assertEquals(server.addrs[2].transport, "tcp");
+      assertEquals(server.addrs[2]!.transport, "tcp");
       assertEquals((server.addrs[2] as Deno.NetAddr).hostname, addrHostname);
       assertEquals((server.addrs[2] as Deno.NetAddr).port, addrPort);
     } finally {
@@ -973,14 +973,14 @@ Deno.test(
     // the expected backoff delay.
     for (let i = 0; i < rejectionCount; i++) {
       assertEquals(
-        listener.acceptCallIntervals[i] >= expectedBackoffDelays[i],
+        listener.acceptCallIntervals[i]! >= expectedBackoffDelays[i]!,
         true,
       );
     }
 
     // Assert that the backoff delay has been reset following successfully
     // accepting a connection, i.e. it doesn't remain at 1000ms.
-    assertEquals(listener.acceptCallIntervals[rejectionCount] < 1000, true);
+    assertEquals(listener.acceptCallIntervals[rejectionCount]! < 1000, true);
   },
 );
 

http/user_agent.ts

@@ -189,11 +189,11 @@ function mapper(
       if (!matchers[j]) {
         break;
       }
-      matches = matchers[j++].exec(ua);
+      matches = matchers[j++]!.exec(ua);
 
       if (matches) {
         for (const processor of processors) {
-          const match = matches[++k];
+          const match = matches[++k]!;
           if (Array.isArray(processor)) {
             if (processor.length === 2) {
               const [prop, value] = processor;