Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node/_util/_util_callbackify_test is failing with canary #1651

Closed
kt3k opened this issue Nov 29, 2021 · 6 comments
Closed

node/_util/_util_callbackify_test is failing with canary #1651

kt3k opened this issue Nov 29, 2021 · 6 comments

Comments

@kt3k
Copy link
Member

kt3k commented Nov 29, 2021

The 2nd case callbackify passes the rejection value as the first argument to the callback is never settled with canary. It was ok with 1.6.3 1.16.3

@kt3k
Copy link
Member Author

kt3k commented Nov 29, 2021

Seems to have started with denoland/deno#12908 . It doesn't have this issue with CLI 1974eb10210832da946ee57fd216b7bc0cf398aa

kt3k added a commit to kt3k/deno_std that referenced this issue Nov 29, 2021
@kt3k
Copy link
Member Author

kt3k commented Nov 29, 2021

callbackify passes arguments to the original and callbackify preserves the this binding seem also affected

@kt3k
Copy link
Member Author

kt3k commented Nov 29, 2021

[node/crypto.Hash] streaming usage in node/crypto_test.ts is also broken in a similar way

@kt3k
Copy link
Member Author

kt3k commented Nov 29, 2021

also node/http_test.ts is affected

@kt3k
Copy link
Member Author

kt3k commented Nov 29, 2021

Reproduced the issue with a smaller example. It seems related to nextTick:

import { nextTick } from "https://deno.land/std@0.116.0/node/_next_tick.ts";
Deno.test("test 1", async () => {
  await new Promise<void>((resolve) => nextTick(resolve));
});
Deno.test("test 2", async () => {
  await new Promise<void>((resolve) => nextTick(resolve));
});

The above example is stuck at the end of test 2

@bartlomieju
Copy link
Member

Fixed by denoland/deno@5178e09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants