Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move internals file in node folder to /node/internal #1707

Closed
12 tasks done
getspooky opened this issue Dec 14, 2021 · 8 comments
Closed
12 tasks done

Refactor: Move internals file in node folder to /node/internal #1707

getspooky opened this issue Dec 14, 2021 · 8 comments

Comments

@getspooky
Copy link
Contributor

getspooky commented Dec 14, 2021

Move internals files like _net.ts , _errors , etc to node/internal .
Target:

@kt3k
Copy link
Member

kt3k commented Dec 15, 2021

@getspooky Thank you for creating this issue!

Right. We should keep the file structure as close as possible to Node.js structure. The above change make sense to me.

BTW node/_core.js is something we invented on our own. Maybe we should keep it somewhere else?

@kt3k
Copy link
Member

kt3k commented Dec 15, 2021

Also deno_std/node/_buffer.js seems corresponding to node/lib/buffer.js. So let's just rename it to deno_std/node/buffer.js in this case.

Please carefully compare node.js lib/ directory and deno_std node/ directory before starting working on each item

@getspooky
Copy link
Contributor Author

getspooky commented Dec 15, 2021

@kt3k thanks for feedback, i will start working on it

@kt3k
Copy link
Member

kt3k commented Dec 15, 2021

Also _timers will conflicts with #1699. Please avoid it at first.

@kt3k
Copy link
Member

kt3k commented Dec 16, 2021

I updated the description, and crossed out some items (_core.ts _events.js _next_tick.ts _utils.ts) which don't seem existing in internal/

@iuioiua
Copy link
Contributor

iuioiua commented Oct 11, 2022

@kt3k, I'll do _readline.mjs. Is there any issue in essentially merging the .mjs and .d.ts files into a .ts file? I gather that .mjs is separated to make following the node version easier to follow.

@kt3k
Copy link
Member

kt3k commented Oct 12, 2022

@iuioiua I think there's no such issue. Do you think we should merge .mjs and .d.ts into .ts?

@kt3k
Copy link
Member

kt3k commented Mar 21, 2023

Looks these are all done now. Thanks for your efforts!

@kt3k kt3k closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants