Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node): clean up debuglog #1931

Merged
merged 2 commits into from
Feb 16, 2022
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Feb 16, 2022

part of #1707

This PR moves node/_util/_debuglog.ts to node/internal/util/debuglog.ts to align the directory structure to node.js code base. This PR also fixes the debug log output format. It reduces the duplicated new lines

Before

$ NODE_DEBUG=* node tls-server.js
NET 96541: 'setupListenHandle' null 8000 4 0 undefined

NET 96541: 'setupListenHandle: create a handle'

NET 96541: 'bind to' '::'

After

$ NODE_DEBUG=* node tls-server.js
NET 96541: 'setupListenHandle' null 8000 4 0 undefined
NET 96541: 'setupListenHandle: create a handle'
NET 96541: 'bind to' '::'

@kt3k kt3k requested a review from bartlomieju as a code owner February 16, 2022 11:57
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 51a00a2 into denoland:main Feb 16, 2022
@kt3k kt3k deleted the cleanup-node-debuglog branch February 16, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants