Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving the examples directory #3463

Closed
not-my-profile opened this issue Jun 23, 2023 · 2 comments · Fixed by #3546
Closed

Moving the examples directory #3463

not-my-profile opened this issue Jun 23, 2023 · 2 comments · Fixed by #3546

Comments

@not-my-profile
Copy link
Contributor

The examples directory currently resides directly next to the directories containing the public API and uses the same naming convention as the other directories containing the public API. Likewise it is also listed in the documentation next to the public APIs.

I think it would make sense to move examples to e.g. _examples to clarify that it's not actually part of the standard library (and I think the _ prefix would also result in the directory being excluded from the documentation page).

@lino-levan
Copy link
Contributor

I personally am of the opinion that there should be no examples in the std repo, and we should move everything to denobyexample or the examples in the manual.

@not-my-profile
Copy link
Contributor Author

Right that would also address my concern of the directory looking like it belongs to the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants