Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: move testing examples elsewhere #3822

Closed
iuioiua opened this issue Nov 20, 2023 · 6 comments · Fixed by #3833
Closed

suggestion: move testing examples elsewhere #3822

iuioiua opened this issue Nov 20, 2023 · 6 comments · Fixed by #3833
Labels
good first issue Good for newcomers

Comments

@iuioiua
Copy link
Contributor

iuioiua commented Nov 20, 2023

std/testing has a bunch of example code. E.g. bdd_examples/ and chai_example.ts. Perhaps these should be moved elsewhere, like denobyexample or examples in the manual, as suggested in #3463. This includes anything with an _example or _examples suffix in std/testing.

@iuioiua iuioiua added good first issue Good for newcomers suggestion a suggestion yet to be agreed labels Nov 20, 2023
@lino-levan
Copy link
Contributor

I'd be in favor of moving them to denobyexamples under a new category.

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 20, 2023

"Testing" category?

@lino-levan
Copy link
Contributor

I think a testing category would make a lot of sense.

@iuioiua
Copy link
Contributor Author

iuioiua commented Nov 20, 2023

I'd be happy to take a look at any PRs in that repo 👍🏾

@karfau
Copy link

karfau commented Dec 4, 2023

Do I understand correctly that the examples have been dropped from this repo before they have been recreated in the other repository?
Luckily the required information is preserved in denoland/denobyexample#111 by pointing to the tree at a state that still contains the examples, but it makes those things really hard to find.

@iuioiua
Copy link
Contributor Author

iuioiua commented Dec 4, 2023

Yes, the example files were removed before being recreated in denobyexample. However, the code snippets were also moved to relevant JSDocs within the std/testing sub-module. See here. And now that you mention it, it should be clarified that the JSDoc examples should probably be moved to denobyexample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants