Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: add ReadStream and createReadStream #1435

Merged
merged 51 commits into from
Mar 24, 2022
Merged

node: add ReadStream and createReadStream #1435

merged 51 commits into from
Mar 24, 2022

Conversation

bartlomieju
Copy link
Member

Mocking some more modules to try vite working in --compat mode.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bartlomieju
bartlomieju commented Oct 21, 2021
View reviewed changes
node/_readline/utils.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Oct 24, 2021
Merged
bartlomieju
bartlomieju commented Oct 31, 2021
View reviewed changes
node/module.ts Outdated Show resolved Hide resolved
node/process.ts Outdated Show resolved Hide resolved
node/process.ts Outdated Show resolved Hide resolved
node/module_all.ts Outdated Show resolved Hide resolved
bartlomieju
bartlomieju commented Nov 2, 2021
View reviewed changes
node/_fs/_fs_unlink.ts Outdated Show resolved Hide resolved
bartlomieju
bartlomieju commented Nov 2, 2021
View reviewed changes
node/process.ts Outdated Show resolved Hide resolved
@bartlomieju bartlomieju mentioned this pull request Nov 9, 2021
Closed
@bartlomieju bartlomieju changed the title chore: mock more node/ modules for vite node: add ReadStream and createReadStream Mar 23, 2022
@bartlomieju bartlomieju mentioned this pull request Mar 23, 2022
Closed
7 tasks
kt3k
kt3k approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@bartlomieju bartlomieju merged commit a9e6090 into denoland:main Mar 24, 2022
@bartlomieju bartlomieju deleted the modules_for_vite branch March 24, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronO AaronO AaronO left review comments

@kt3k kt3k kt3k approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bartlomieju @CLAassistant @kt3k @AaronO @lucacasonato