Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): add http.request #1712

Merged
merged 11 commits into from
Dec 16, 2021
Merged

feat(node): add http.request #1712

merged 11 commits into from
Dec 16, 2021

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 15, 2021

part of #1703
depends on #1706

bnoordhuis
bnoordhuis approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

node/internal/timers.ts Outdated Show resolved Hide resolved
node/internal/dtrace.ts Outdated
DTRACE_HTTP_SERVER_RESPONSE,
DTRACE_NET_SERVER_CONNECTION,
DTRACE_NET_STREAM_END,
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you copied this from node but we're never going to have dtrace support so you might as well simplify this file to always export stubs.

node/internal_binding/dtrace.ts Outdated
}
export function DTRACE_NET_STREAM_END() {
notImplemented();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And remove this file (maybe config.ts too)

@kt3k
Copy link
Member Author

kt3k commented Dec 16, 2021

I'll continue working on a few more points:

  • the server responds with an empty response with the code res.write("foo"); res.end(), which prevents some test cases passing.
  • the client sometimes hangs with socket hang up error. e.g. in test-http-client-get-url.js, I still don't find the reason of this

@kt3k kt3k changed the title WIP feat(node): add http.request feat(node): add http.request Dec 16, 2021
@kt3k kt3k marked this pull request as ready for review December 16, 2021 09:48
@kt3k kt3k requested a review from bartlomieju as a code owner December 16, 2021 09:49
bartlomieju
bartlomieju approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, great work @kt3k

@kt3k
Copy link
Member Author

kt3k commented Dec 16, 2021

Thanks for your reviews!

@kt3k kt3k merged commit 068f16f into denoland:main Dec 16, 2021
@kt3k kt3k deleted the feat/node-http-client-request branch December 16, 2021 10:42
@bnoordhuis bnoordhuis mentioned this pull request Dec 16, 2021
Closed
@kt3k kt3k mentioned this pull request Dec 16, 2021
Closed
6 tasks
@ry ry mentioned this pull request Dec 22, 2021
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt3k @bnoordhuis @bartlomieju