Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): don't emit exit twice #1753

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix(node): don't emit exit twice #1753

merged 1 commit into from
Dec 23, 2021

Conversation

bartlomieju
Copy link
Member

Fixes #1752

Related to #1628

kt3k
kt3k approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@bartlomieju bartlomieju merged commit 09802f3 into denoland:main Dec 23, 2021
@bartlomieju bartlomieju deleted the double_exit_emit branch December 23, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: 'exit' event is emitted twice when process.exit() is called
2 participants
@bartlomieju @kt3k