Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): fix fs.write/fs.writeAll #1832

Merged
merged 2 commits into from
Jan 19, 2022
Merged

fix(node): fix fs.write/fs.writeAll #1832

merged 2 commits into from
Jan 19, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 18, 2022

  • Reverted the last commit of feat(node/fs): fs.write()/fs.writeSync() #1817 as writeAll here is not compatible with what streams/conversion.ts provides.
  • Enabled test-fs-write-buffer.js test case.
  • Also added offset range check, which is tested in the above test suite.

@kt3k kt3k mentioned this pull request Jan 18, 2022
Closed
7 tasks
bartlomieju
bartlomieju approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit b79c541 into denoland:main Jan 19, 2022
@kt3k kt3k deleted the fix/fix-fs-write branch January 19, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@bnoordhuis bnoordhuis Awaiting requested review from bnoordhuis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju