Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node): export URLSearchParams via url module #2056

Merged
merged 3 commits into from
Mar 24, 2022
Merged

feat(node): export URLSearchParams via url module #2056

merged 3 commits into from
Mar 24, 2022

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Mar 23, 2022

This PR adds URLSearchParams in default export of url module in std/node. This improves vite compatibility, ref

part of #2055

@kt3k kt3k requested a review from bartlomieju as a code owner March 23, 2022 10:46
@kt3k
Copy link
Member Author

kt3k commented Mar 23, 2022

CI is blocked by #2057

bartlomieju
bartlomieju approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit a4fbce7 into denoland:main Mar 24, 2022
@kt3k kt3k deleted the feat/node-url-search-params branch March 24, 2022 04:33
@kt3k kt3k mentioned this pull request Mar 24, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @bartlomieju