Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add exists for fs modules #260

Merged
merged 2 commits into from
Mar 11, 2019
Merged

feat: add exists for fs modules #260

merged 2 commits into from
Mar 11, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Mar 11, 2019

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@axetroy axetroy mentioned this pull request Mar 11, 2019
Closed
13 tasks
ry
ry reviewed Mar 11, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool - looks good. Can we rename this to fs/exists.ts, exists(), existsSync() ?

@axetroy
Copy link
Contributor Author

axetroy commented Mar 11, 2019

@ry Good idea. deno does not have an API like exists. we can rename it.

ry
ry approved these changes Mar 11, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@ry ry merged commit 142a1c6 into denoland:master Mar 11, 2019
@axetroy axetroy deleted the path_exists branch March 11, 2019 17:14
@axetroy axetroy changed the title feat: add pathExists for fs modules feat: add exists for fs modules Mar 11, 2019
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@axetroy @ry
add fs/exists (denoland/std#260)
ef6d932 
Original: denoland/std@142a1c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axetroy @CLAassistant @ry