Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ensureSymlink/ensureSymlinkSync for fs modules #268

Merged
merged 17 commits into from
Apr 21, 2019
Merged

feat: add ensureSymlink/ensureSymlinkSync for fs modules #268

merged 17 commits into from
Apr 21, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented Mar 13, 2019 •
edited
Loading

part of #261

not implement in Windows now.

@axetroy axetroy mentioned this pull request Mar 13, 2019
Closed
13 tasks
@axetroy axetroy changed the title feat: add ensure_syslink for fs feat: add ensureSyslink/ensureSyslinkSnc for fs Mar 13, 2019
@axetroy axetroy changed the title feat: add ensureSyslink/ensureSyslinkSnc for fs feat: add ensureSyslink/ensureSyslinkSync for fs modules Mar 14, 2019
zekth
zekth reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename from Syslink to Symlink

fs/ensure_syslink_test.ts Outdated Show resolved Hide resolved
@axetroy axetroy changed the title feat: add ensureSyslink/ensureSyslinkSync for fs modules feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 14, 2019
zekth
zekth reviewed Mar 14, 2019
View reviewed changes
Copy link
Contributor

@zekth zekth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think Should skip is a good solution. I'd test assertThrows(ensureSymlink()) if deno.platform === 'win'

@axetroy
Copy link
Contributor Author

axetroy commented Mar 14, 2019

I don't think Should skip is a good solution. I'd test assertThrows(ensureSymlink()) if deno.platform === 'win'

or should wait for support windows?

@axetroy axetroy changed the title feat: add ensureSymlink/ensureSymlinkSync for fs modules [WPI] feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 18, 2019
@axetroy axetroy changed the title [WPI] feat: add ensureSymlink/ensureSymlinkSync for fs modules [WIP] feat: add ensureSymlink/ensureSymlinkSync for fs modules Mar 18, 2019
@zekth
Copy link
Contributor

zekth commented Apr 17, 2019

You may have to do a conditionnal if(win) in the tests due to the notimplemend status. No? Seems legit to me.

@axetroy axetroy changed the title [WIP] feat: add ensureSymlink/ensureSymlinkSync for fs modules feat: add ensureSymlink/ensureSymlinkSync for fs modules Apr 21, 2019
@axetroy
Copy link
Contributor Author

axetroy commented Apr 21, 2019 •
edited
Loading

@zekth Yes. you are right.

I found that denoland/deno has many places to write like this, I should change it.

ry
ry approved these changes Apr 21, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 8d1b01c into denoland:master Apr 21, 2019
@axetroy axetroy deleted the ensure_syslink branch April 22, 2019 06:22
This was referenced Apr 22, 2019
Merged
Merged
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@axetroy @ry
feat: add ensureSymlink/ensureSymlinkSync for fs modules (denoland/st…
f146938 
…d#268)

Original: denoland/std@8d1b01c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekth zekth zekth left review comments

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axetroy @zekth @ry