Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node/child_process): enable promisify(execFile) #3161

Merged
merged 4 commits into from
Feb 3, 2023
Merged

fix(node/child_process): enable promisify(execFile) #3161

merged 4 commits into from
Feb 3, 2023

Conversation

PolarETech
Copy link
Contributor

@PolarETech PolarETech commented Feb 2, 2023 •
edited
Loading

@PolarETech PolarETech marked this pull request as ready for review February 2, 2023 21:39
@PolarETech PolarETech requested a review from kt3k as a code owner February 2, 2023 21:39
@PolarETech PolarETech marked this pull request as draft February 2, 2023 22:13
@PolarETech PolarETech marked this pull request as ready for review February 3, 2023 06:41
kt3k
kt3k approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice work!

@kt3k kt3k merged commit 1cda923 into denoland:main Feb 3, 2023
@PolarETech PolarETech deleted the issue-3145 branch February 3, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Promisified execFile returns undefined in Deno
2 participants
@PolarETech @kt3k