Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentionned in: #333
Here is a draft of e2e testing in
chrome headless
browser using puppeteer.First of all there is some additionnal step to setup the environment:
npm install puppeteer # This will provide the binary to use chrome Headless
In the
./strings/e2e/
folder there is 2 files:How the test is done:
If the test pass the console prompt OK, otherwise FAILED. And we inspect the output.
Also i'd prefer to use the same asserts as the tests itselves and use a more generic way to implement Browser testing. Any idea is welcome.
Added to this, once denoland/deno#2089 will land it will be easier to wrap everything in a more generic approach.
NOTE: Atm it's using the default chrome path. There is some differences between environment, got to fix it.