Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(path): format test names #3755

Merged
merged 2 commits into from
Nov 1, 2023
Merged

refactor(path): format test names #3755

merged 2 commits into from
Nov 1, 2023

Conversation

timreichen
Copy link
Contributor

Ref: #3754

I added posix and win32 as prefixes to the function name (for example posix.toFileUrl()).

Question: lots of tests do not have a description. Most of these would repeat the information in the function name. Do all tests need a description?

@timreichen timreichen requested a review from kt3k as a code owner October 31, 2023 21:33
@github-actions github-actions bot added the path label Oct 31, 2023
@timreichen timreichen changed the title chore: rename path test names chore: format path test names Oct 31, 2023
@timreichen timreichen changed the title chore: format path test names chore(path): format test names Oct 31, 2023
@timreichen timreichen changed the title chore(path): format test names refactor(path): format test names Oct 31, 2023
kt3k
kt3k reviewed Nov 1, 2023
View reviewed changes
path/glob_test.ts Outdated Show resolved Hide resolved
kt3k
kt3k approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit 9560e44 into denoland:main Nov 1, 2023
11 checks passed
@kt3k
Copy link
Member

kt3k commented Nov 1, 2023

Question: lots of tests do not have a description. Most of these would repeat the information in the function name. Do all tests need a description?

Can you provide an example?

@timreichen
Copy link
Contributor Author

Question: lots of tests do not have a description. Most of these would repeat the information in the function name. Do all tests need a description?

Can you provide an example?

For example in basename_test.ts: There are only two tests (posix.basename() and posix.basename()) I guess the description would be something like returns the basename of a posix path and returns the basename of a win32 path respectively.

@kt3k
Copy link
Member

kt3k commented Nov 1, 2023

I think it's fine to omit the description in such cases

@timreichen timreichen deleted the path_format_test_names branch January 7, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
path
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @kt3k