Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(datetime): replace enum with object #3836

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

realpha
Copy link
Contributor

@realpha realpha commented Nov 22, 2023

This PR replaces the used typescript enum in the datetime module with a
as const object as requested here

As this enum is only used internally, merging this change wouldn't constitute a
breaking change.

History:

  • chore(root): ignore .tool-versions
  • feat(datetime): replace enum with const object

@realpha realpha requested a review from kt3k as a code owner November 22, 2023 20:57
@CLAassistant
Copy link

CLAassistant commented Nov 22, 2023

CLA assistant check
All committers have signed the CLA.

.gitignore Outdated Show resolved Hide resolved
@iuioiua iuioiua changed the title chore: deprecate datetime enum refactor(datetime): replace enum with object Nov 22, 2023
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙏🏾

@iuioiua iuioiua merged commit 830d387 into denoland:main Nov 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants