Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(streams): complete documentation #3893

Merged
merged 2 commits into from
Dec 4, 2023
Merged

chore(streams): complete documentation #3893

merged 2 commits into from
Dec 4, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 4, 2023

Do note that a couple of changes for deprecated APIs were made just to make the linter happy.

Towards #3878
Towards #3764

@iuioiua iuioiua requested a review from lucacasonato December 4, 2023 02:37
@iuioiua iuioiua marked this pull request as ready for review December 4, 2023 02:52
streams/buffer.ts Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua enabled auto-merge (squash) December 4, 2023 06:11
@iuioiua iuioiua merged commit 4df10f6 into main Dec 4, 2023
10 checks passed
@iuioiua iuioiua deleted the streams-jsdocs branch December 4, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants