Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(assert): correct test names #3911

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

scarf005
Copy link
Contributor

@scarf005 scarf005 commented Dec 8, 2023

Summary

Details

  • assert/_diff_test.ts
  • assert/_format_test.ts
  • assert/assert_almost_equals_test.ts
  • assert/assert_array_includes_test.ts
  • assert/assert_equals_test.ts
  • assert/assert_exists_test.ts
  • assert/assert_false_test.ts
  • assert/assert_greater_or_equal_test.ts
  • assert/assert_greater_test.ts
  • assert/assert_instance_of_test.ts
  • assert/assert_is_error_test.ts
  • assert/assert_less_or_equal_test.ts
  • assert/assert_less_test.ts
  • assert/assert_match_test.ts
  • assert/assert_not_equals_test.ts
  • assert/assert_not_instance_of_test.ts
  • assert/assert_not_match_test.ts
  • assert/assert_not_strict_equals_test.ts
  • assert/assert_object_match_test.ts
  • assert/assert_rejects_test.ts
  • assert/assert_strict_equals_test.ts
  • assert/assert_string_includes_test.ts
  • assert/assert_throws_test.ts
  • assert/equal_test.ts
  • assert/fail_test.ts
  • assert/shared_test.ts
  • assert/unimplemented_test.ts
  • assert/unreachable_test.ts

@scarf005 scarf005 requested a review from kt3k as a code owner December 8, 2023 03:49
@github-actions github-actions bot added the assert label Dec 8, 2023
@scarf005 scarf005 marked this pull request as draft December 8, 2023 03:50
@kt3k kt3k marked this pull request as ready for review December 8, 2023 09:03
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@scarf005
Copy link
Contributor Author

scarf005 commented Dec 8, 2023

for other test names in assert, should i open additional PRs, or keep update this one?

@kt3k
Copy link
Member

kt3k commented Dec 8, 2023

Please open new PRs

@kt3k kt3k merged commit 9b9be2a into denoland:main Dec 8, 2023
12 checks passed
@scarf005 scarf005 deleted the fix-assert-object-match branch December 8, 2023 09:06
@kt3k
Copy link
Member

kt3k commented Dec 8, 2023

We generally prefer nicely sized (like < 300 lines) multiple PRs if it's not too difficult to split into pieces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants