Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move posix and win implementations in fs/path/mod.ts to separate file #397

Merged
merged 3 commits into from
May 13, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented May 13, 2019

close #396

fs/path/posix.ts Outdated Show resolved Hide resolved

import { isWindows } from "./constants.ts";

const path = isWindows ? _win32 : _posix;
Copy link
Contributor Author

@axetroy axetroy May 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here rename module variable to path.

Just in case of once support for the commonjs module in the future

- const module = isWindows ?
+ const path = isWindows ?

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -thanks !

@ry ry merged commit b6a7b78 into denoland:master May 13, 2019
@axetroy axetroy deleted the path_separateb branch May 13, 2019 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move posix and win implementations in fs/path/mod.ts to separate files.
2 participants