Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(archive): format test names #3984

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

timreichen
Copy link
Contributor

Ref: #3754

@timreichen timreichen requested a review from kt3k as a code owner December 18, 2023 13:30
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@iuioiua iuioiua merged commit 228d29e into denoland:main Dec 18, 2023
10 checks passed
@timreichen timreichen deleted the untar_-format_test_names branch December 18, 2023 22:23
@iuioiua
Copy link
Contributor

iuioiua commented Dec 19, 2023

Note to self: use these names in #1985.

@kt3k
Copy link
Member

kt3k commented Dec 19, 2023

I wonder if the expression like Tar() makes sense as Tar is a class here

@iuioiua
Copy link
Contributor

iuioiua commented Dec 19, 2023

What do you suggest?

@kt3k
Copy link
Member

kt3k commented Dec 19, 2023

If a test case is simple enough, I think we can use something like:

Deno.test("Tar", (t) => {
  t.step("append() blah blah", () => {});
  t.step("getReader() blah blah", () => {});
});

@kt3k
Copy link
Member

kt3k commented Dec 19, 2023

But if a test case is complex and needs to involve multiple APIs (in other words, integration test type ones), maybe we need to allow more arbitrary format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants