Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(data_structures): format test names #3991

Merged
merged 6 commits into from
Dec 28, 2023
Merged

test(data_structures): format test names #3991

merged 6 commits into from
Dec 28, 2023

Conversation

timreichen
Copy link
Contributor

Ref: #3754

@timreichen timreichen requested a review from kt3k as a code owner December 18, 2023 17:02
iuioiua
iuioiua suggested changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, the use of the word "checks" doesn't make much sense to me. Are you able to sweep through and tweak?

data_structures/binary_heap_test.ts Outdated Show resolved Hide resolved
data_structures/binary_heap_test.ts Outdated Show resolved Hide resolved
timreichen and others added 3 commits December 20, 2023 10:20
@timreichen @iuioiua
Update data_structures/binary_heap_test.ts
503da41 
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
@timreichen @iuioiua
Update data_structures/binary_heap_test.ts
3392e33 
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
@iuioiua
fix: adjust use of "checks"
4f54bfa
iuioiua
iuioiua approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some adjustments. Now, LGTM. Thank you.

@kt3k kt3k changed the title refactor(data_structures): format test names test(data_structures): format test names Dec 28, 2023
kt3k
kt3k approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 8670197 into denoland:main Dec 28, 2023
12 checks passed
@timreichen timreichen deleted the data_structures_format_test_names branch December 28, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
data-structures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timreichen @kt3k @iuioiua