Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(text): format test names #3993

Merged
merged 4 commits into from
Dec 20, 2023
Merged

refactor(text): format test names #3993

merged 4 commits into from
Dec 20, 2023

Conversation

timreichen
Copy link
Contributor

Ref: #3754

@timreichen timreichen requested a review from kt3k as a code owner December 18, 2023 17:56
@github-actions github-actions bot added the text label Dec 18, 2023
iuioiua
iuioiua suggested changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once "checks" usage is replaced with "handles".

@timreichen
Copy link
Contributor Author

LGTM once "checks" usage is replaced with "handles".

I replaced "checks" with "handles".

iuioiua
iuioiua approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@iuioiua iuioiua merged commit c3cfce4 into denoland:main Dec 20, 2023
12 checks passed
@timreichen timreichen deleted the text-_format_test_names branch December 20, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
text
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua