Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(dotenv): format test names #3996

Merged
merged 5 commits into from
Dec 20, 2023
Merged

refactor(dotenv): format test names #3996

merged 5 commits into from
Dec 20, 2023

Conversation

timreichen
Copy link
Contributor

Ref: #3754

@timreichen timreichen requested a review from kt3k as a code owner December 18, 2023 21:13
kt3k
kt3k reviewed Dec 19, 2023
View reviewed changes
dotenv/parse_test.ts Outdated Show resolved Hide resolved
kt3k
kt3k reviewed Dec 19, 2023
View reviewed changes
dotenv/load_test.ts Outdated Show resolved Hide resolved
@kt3k
Copy link
Member

kt3k commented Dec 19, 2023

many of checks usages sound strange to me.

timreichen and others added 3 commits December 20, 2023 10:02
@timreichen @kt3k
Update dotenv/parse_test.ts
7ec6af9 
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@timreichen @kt3k
Update dotenv/load_test.ts
e2608f7 
Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
@timreichen
update test names
061fe56
@timreichen
Copy link
Contributor Author

many of checks usages sound strange to me.

I had another look and updated some test names.

iuioiua
iuioiua approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iuioiua iuioiua merged commit 1589bf3 into denoland:main Dec 20, 2023
12 checks passed
@timreichen timreichen deleted the dotenv_format_test_names branch December 20, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k left review comments

@iuioiua iuioiua iuioiua approved these changes

Assignees
No one assigned
Labels
dotenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timreichen @kt3k @iuioiua