-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add some missing explicit types #3997
Merged
iuioiua
merged 4 commits into
denoland:main
from
dsherret:refactor_missing_return_types_2
Dec 19, 2023
Merged
refactor: add some missing explicit types #3997
iuioiua
merged 4 commits into
denoland:main
from
dsherret:refactor_missing_return_types_2
Dec 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pes as `@internal`
github-actions
bot
added
testing
http
fmt
csv
datetime
dotenv
front-matter
html
io
log
media-types
path
regexp
semver
toml
yaml
expect
text
cli
data-structures
ini
msgpack
labels
Dec 18, 2023
dsherret
commented
Dec 18, 2023
iuioiua
reviewed
Dec 18, 2023
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
dsherret
changed the title
refactor: add some missing explicit types and mark some non-exported types as
refactor: add some missing explicit types
Dec 19, 2023
@internal
iuioiua
approved these changes
Dec 19, 2023
iuioiua
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will improve the deno doc output.