Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add some missing explicit types #3997

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

dsherret
Copy link
Member

This will improve the deno doc output.

cli/parse_args.ts Outdated Show resolved Hide resolved
expect/fn.ts Outdated Show resolved Hide resolved
dsherret and others added 2 commits December 18, 2023 17:35
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
@dsherret dsherret changed the title refactor: add some missing explicit types and mark some non-exported types as @internal refactor: add some missing explicit types Dec 19, 2023
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@iuioiua
Copy link
Contributor

iuioiua commented Dec 19, 2023

Towards #3764 and #3878

@iuioiua iuioiua enabled auto-merge (squash) December 19, 2023 00:24
@iuioiua iuioiua merged commit b080361 into denoland:main Dec 19, 2023
10 checks passed
@dsherret dsherret deleted the refactor_missing_return_types_2 branch December 19, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants