Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): document milliseconds unit for Spinner.interval #4017

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix(cli): document milliseconds unit for Spinner.interval #4017

merged 1 commit into from
Dec 22, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 21, 2023

Addresses #3968 (comment)

CC @jsejcksn

@iuioiua iuioiua requested a review from kt3k as a code owner December 21, 2023 21:54
@github-actions github-actions bot added the cli label Dec 21, 2023
kt3k
kt3k approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@iuioiua iuioiua merged commit 4a1de2c into main Dec 22, 2023
12 checks passed
@iuioiua iuioiua deleted the spinner-internal-ms branch December 22, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsejcksn jsejcksn jsejcksn approved these changes

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @kt3k @jsejcksn