Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove completed todo item #406

Merged
merged 2 commits into from
May 14, 2019
Merged

remove completed todo item #406

merged 2 commits into from
May 14, 2019

Conversation

axetroy
Copy link
Contributor

@axetroy axetroy commented May 14, 2019 •
edited
Loading

denoland/deno#2169 have been resolve.

ry
ry approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit d097e31 into denoland:master May 14, 2019
@axetroy axetroy deleted the outdate_code branch May 14, 2019 19:13
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
@axetroy @ry
fs: Remove completed todo item (denoland/std#406)
a3de8c3 
Original: denoland/std@d097e31
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
@hashrock
fix: use TabsBar style at TimeSelector (denoland#406)
7c8763c 
I like TabsBar style that we're using on the dashboard, so I replaced
with it.
It looks different from Header Nav, and I think the selection state is
easy to see. wdyt?

Before: 
<img width="826" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/3dfa093a-5a3c-4b0d-b37f-71487eb77737">

After: 
<img width="834" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/e8c92cd1-cbe6-4a24-b3c5-6a26af58862c">

<img width="827" alt="image"
src="https://github.com/denoland/saaskit/assets/3132889/b4f38ca4-2148-4be8-9d50-149aae490cbe">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axetroy @ry