refactor(testing): prepare for noUncheckedIndexedAccess
#4084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syhol
commented
Jan 4, 2024
syhol
commented
Jan 4, 2024
iuioiua
suggested changes
Jan 4, 2024
Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com>
|
All comments addressed, ready for another review 🙇 |
iuioiua
reviewed
Jan 4, 2024
testing/mock_test.ts
Outdated
Comment on lines
1785
to
1790
| assertThrows(() => callback()); | ||
| assertEquals(callback("a"), "a"); | ||
| assertEquals(callback("b", "c"), "b"); | ||
| callback = returnsArg(1); | ||
| assertEquals(callback(), undefined); | ||
| assertEquals(callback("a"), undefined); | ||
| assertThrows(() => callback()); | ||
| assertThrows(() => callback("a")); |
There was a problem hiding this comment.
Following on from this conversation #4084 (comment) the choice was either changing the type or changing the runtime behaviour, you settled on changing the runtime behaviour so the tests needed to change to account for the new behaviour.
There was a problem hiding this comment.
Oh! I see. Hm... Ok. I now better understand how it affected the public API. On second thought, it might be better to add undefined to the return type instead of error-checking. Sorry, are you able to do that?
There was a problem hiding this comment.
No problem, I could have made it more clear. I'll push the change soon.
iuioiua
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling all noUncheckedIndexedAccess issues for the testing module, tracked in #4040