Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expect): prepare for noUncheckedIndexedAccess #4150

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

syhol
Copy link
Contributor

@syhol syhol commented Jan 10, 2024

Handling all noUncheckedIndexedAccess issues for the expect module, tracked in #4040

BUG FIX INCLUDED

Looks like toHaveBeenNthCalledWith failure case was checking with the wrong variable, I'll call out where I've updated it to now check the correct variable.

@syhol syhol requested a review from kt3k as a code owner January 10, 2024 16:22
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@iuioiua iuioiua merged commit 508f3f5 into denoland:main Jan 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants