Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set up workspace publish from CI #4210

Merged
merged 2 commits into from
Jan 26, 2024
Merged

chore: set up workspace publish from CI #4210

merged 2 commits into from
Jan 26, 2024

Conversation

lucacasonato
Copy link
Member

For every PR, we now run the convert_to_workspace.ts script to ensure that std/ is still workspace compatible, and we run deno publish --dry-run to ensure there are no FastCheck errors.

@lucacasonato lucacasonato force-pushed the workspace_publish branch 3 times, most recently from 90d6caa to d17c386 Compare January 16, 2024 10:30
@kt3k kt3k requested a review from iuioiua January 16, 2024 14:47
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

_tools/convert_to_workspace.ts Show resolved Hide resolved
for await (const entry of Deno.readDir(".")) {
if (
entry.isDirectory && !entry.name.startsWith(".") &&
!entry.name.startsWith("_") && entry.name !== "coverage"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: keep this in mind when working on #4200 as we might be adding an "internal" folder.

_tools/packages.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, most of the internal tools break once this script is applied. Please allow Yoshiya and I to go through it.

Note: post-run check can be done by running DENO_UNSTABLE_WORKSPACES=1 deno task ok.

_tools/convert_to_workspace.ts Outdated Show resolved Hide resolved
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the script is run, tests and some internal checks fail (specifically the test and lint tasks). IIUC, these shouldn't be blockers for adding this check but should be addressed before workspaces functionality is officially enabled. LGTM.

@kt3k kt3k merged commit 6dad760 into main Jan 26, 2024
13 checks passed
@kt3k kt3k deleted the workspace_publish branch January 26, 2024 07:51
@kt3k kt3k mentioned this pull request Jan 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants