-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set up workspace publish from CI #4210
Conversation
90d6caa
to
d17c386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice!
for await (const entry of Deno.readDir(".")) { | ||
if ( | ||
entry.isDirectory && !entry.name.startsWith(".") && | ||
!entry.name.startsWith("_") && entry.name !== "coverage" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: keep this in mind when working on #4200 as we might be adding an "internal" folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, most of the internal tools break once this script is applied. Please allow Yoshiya and I to go through it.
Note: post-run check can be done by running DENO_UNSTABLE_WORKSPACES=1 deno task ok
.
d17c386
to
b12b06f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the script is run, tests and some internal checks fail (specifically the test
and lint
tasks). IIUC, these shouldn't be blockers for adding this check but should be addressed before workspaces functionality is officially enabled. LGTM.
For every PR, we now run the
convert_to_workspace.ts
script to ensure that std/ is still workspace compatible, and we rundeno publish --dry-run
to ensure there are no FastCheck errors.