Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove environment variable functionality notice in warnOnDeprecatedApi() #4227

Merged
merged 1 commit into from
Jan 23, 2024
Merged

refactor: remove environment variable functionality notice in warnOnDeprecatedApi() #4227

merged 1 commit into from
Jan 23, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jan 23, 2024

To align it with the runtime. See denoland/deno#21939 (comment)

@iuioiua iuioiua requested a review from kt3k as a code owner January 23, 2024 03:42
kt3k
kt3k approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuioiua iuioiua merged commit f5547f4 into main Jan 23, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-warnOnDeprecatedApi-env branch January 23, 2024 04:02
@kt3k kt3k mentioned this pull request Jan 31, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k