Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): remove log private methods/properties underscore #4243

Merged
merged 2 commits into from
Jan 27, 2024

Conversation

eryue0220
Copy link
Contributor

This pr is to solve #4103

@eryue0220 eryue0220 requested a review from kt3k as a code owner January 27, 2024 08:31
@github-actions github-actions bot added the log label Jan 27, 2024
@eryue0220 eryue0220 changed the title fix(expect): remove log private methods/properties underscore fix(log): remove log private methods/properties underscore Jan 27, 2024
@kt3k kt3k changed the title fix(log): remove log private methods/properties underscore refactor(log): remove log private methods/properties underscore Jan 27, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit aad9999 into denoland:main Jan 27, 2024
12 checks passed
@eryue0220 eryue0220 deleted the chore/remove-log-understcore branch January 28, 2024 00:19
kt3k pushed a commit to kt3k/deno_std that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants