Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(path): remove glob.ts files #4259

Merged
merged 2 commits into from
Feb 2, 2024
Merged

BREAKING(path): remove glob.ts files #4259

merged 2 commits into from
Feb 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Feb 1, 2024

Users should use the file corresponding to the glob-related function instead. E.g. path/is_glob.ts for isGlob().

Note: the deprecation notices for GlobOptions and GlobToRegExpOptions were missed in the deprecation PR. However, their corresponding functions were. These types are now exported from the files that use them.

Deprecation was made in #4152.
Original proposal in #4071.

CC @lino-levan

@iuioiua iuioiua requested a review from kt3k as a code owner February 1, 2024 06:12
@github-actions github-actions bot added the path label Feb 1, 2024
@github-actions github-actions bot added the fs label Feb 1, 2024
@lino-levan
Copy link
Contributor

Seems reasonable to me. Thanks for the great work as usual Asher.

@iuioiua iuioiua enabled auto-merge (squash) February 1, 2024 07:43
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit f974a22 into main Feb 2, 2024
12 checks passed
@iuioiua iuioiua deleted the remove-path-glob branch February 2, 2024 05:48
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 2, 2024
…0/deno_std into crypto-noUncheckedIndexedAccess

* 'crypto-noUncheckedIndexedAccess' of github.com:eryue0220/deno_std:
  refactor(console): prepare for `noUncheckedIndexedAccess` (denoland#4269)
  refactor(collections): prepare for `noUncheckedIndexedAccess` (denoland#4268)
  refactor(semver): cleanup comparison functions (denoland#4266)
  chore(semver): postpone removal versions of some APIs (denoland#4267)
  BREAKING(log): remove `WARNING` log level (denoland#4258)
  BREAKING(semver): remove `rangeFormat()` (denoland#4265)
  BREAKING(semver): remove `sort()` (denoland#4264)
  BREAKING(path): remove `separator.ts` files (denoland#4260)
  BREAKING(path): remove `glob.ts` files (denoland#4259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants