Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fmt): prepare for noUncheckedIndexedAccess #4276

Merged
merged 4 commits into from
Mar 5, 2024
Merged

refactor(fmt): prepare for noUncheckedIndexedAccess #4276

merged 4 commits into from
Mar 5, 2024

Conversation

eryue0220
Copy link
Contributor

Ref: #4040

@eryue0220 eryue0220 requested a review from kt3k as a code owner February 4, 2024 14:46
@github-actions github-actions bot added the fmt label Feb 4, 2024
iuioiua
iuioiua reviewed Feb 4, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see #4275 (review)

@eryue0220 eryue0220 marked this pull request as draft February 5, 2024 09:21
@eryue0220
Copy link
Contributor Author

@iuioiua

Sorry for the late response, this pr is ready.

@eryue0220 eryue0220 marked this pull request as ready for review February 28, 2024 06:59
iuioiua
iuioiua reviewed Mar 2, 2024
View reviewed changes
fmt/printf.ts Show resolved Hide resolved
iuioiua
iuioiua approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you.

@iuioiua iuioiua merged commit e1561a9 into denoland:main Mar 5, 2024
12 checks passed
@eryue0220 eryue0220 deleted the feat/fmt-noUncheckedIndexedAccess branch March 6, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
fmt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eryue0220 @iuioiua