Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation(semver): deprecate reverseSort() #4280

Merged
merged 3 commits into from
Feb 7, 2024
Merged

deprecation(semver): deprecate reverseSort() #4280

merged 3 commits into from
Feb 7, 2024

Conversation

timreichen
Copy link
Contributor

Deprecates reverseSort() function

This function seems like a really special user case and trivial by using compare().

ref: #3948

@timreichen timreichen requested a review from kt3k as a code owner February 5, 2024 20:13
@github-actions github-actions bot added the semver label Feb 5, 2024
iuioiua
iuioiua reviewed Feb 5, 2024
View reviewed changes
semver/reverse_sort.ts Outdated Show resolved Hide resolved
iuioiua
iuioiua approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 8623f4b into denoland:main Feb 7, 2024
12 checks passed
@iuioiua iuioiua mentioned this pull request Mar 1, 2024
Merged
@timreichen timreichen deleted the semver_deprecate_reverse_sort branch July 2, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timreichen @iuioiua