Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(semver): remove SemVerRange and isSemVerRange() #4295

Merged
merged 2 commits into from
Feb 9, 2024
Merged

BREAKING(semver): remove SemVerRange and isSemVerRange() #4295

merged 2 commits into from
Feb 9, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Feb 9, 2024

This change removes the deprecated SemVerRange type from std/semver. This includes the removal of isSemVerRange() as well.

Users should migrate to using the Range type and isRange() instead.

Original proposal: #4059
Deprecation PR: #4161

CC @timreichen

@iuioiua iuioiua requested a review from kt3k as a code owner February 9, 2024 00:10
@github-actions github-actions bot added the semver label Feb 9, 2024
@iuioiua iuioiua mentioned this pull request Feb 9, 2024
Closed
@iuioiua iuioiua enabled auto-merge (squash) February 9, 2024 10:23
kt3k
kt3k approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@iuioiua iuioiua merged commit 083a2b1 into main Feb 9, 2024
10 checks passed
@iuioiua iuioiua deleted the remove-semver-semverrange branch February 9, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
semver
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k