Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename underscore packages to hyphens #4325

Closed
wants to merge 1 commit into from

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Feb 13, 2024

needs to add backwards compatible packages

@crowlKats crowlKats requested a review from kt3k as a code owner February 13, 2024 18:55
@crowlKats crowlKats changed the title rename underscore packages to hyphens refactor: rename underscore packages to hyphens Feb 13, 2024
@timreichen
Copy link
Contributor

Was this discussed somewhere?

@crowlKats
Copy link
Member Author

@timreichen jsr changed its naming policy to use hyphens instead of underscores.

@kt3k
Copy link
Member

kt3k commented Feb 14, 2024

How about doing these renames in _tools/convert_to_workspace.ts? That will only affects jsr version of the standard library.

@timreichen
Copy link
Contributor

That is strange. Is there an issue you can link to about why that change was made? Using hyphens instead of underscores directly violates the deno style guide.

@cknight
Copy link
Contributor

cknight commented Feb 14, 2024

@iuioiua
Copy link
Contributor

iuioiua commented Feb 22, 2024

Closing as this has been superseded by #4357.

@iuioiua iuioiua closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants