Added isGlob function #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
May 22, 2019
| @@ -138,4 +138,120 @@ testWalk( | |||
| } | |||
| ); | |||
|
|
|||
| test({ | |||
| name: "isGlob: pattern to test", | |||
There was a problem hiding this comment.
There should be some test cases testing that something is not glob, eg. assert(!isGlob("foo.js"));
There was a problem hiding this comment.
The test cases include both valid and invalid glob patterns,
I have used these test cases.
|
Is this an fs thing or a string thing? Glob patterns can be expressed in lots of other ways. Yes, they are mainly used to match lists of files, but they can also be used with URI matching too. |
kt3k
reviewed
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to issue #424