Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semver): fix parse_range for >x.y pattern #4350

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Conversation

javihernant
Copy link
Contributor

fix parse_range behaviour in ranges containing the greater than operator

fixes issue #4344

fix parse_range behaviour in ranges containing the greater than
operator

fixes issue denoland#4344
@javihernant javihernant requested a review from kt3k as a code owner February 17, 2024 18:58
@kt3k
Copy link
Member

kt3k commented Feb 18, 2024

Thanks for the PR! Can you add test cases which this change fixes? nevermind. I added a test case 167b4cf

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@kt3k kt3k changed the title fix(semver): fix parse_range unexpected behaviour fix(semver): fix parse_range with wildcard patch version Feb 18, 2024
@kt3k kt3k changed the title fix(semver): fix parse_range with wildcard patch version fix(semver): fix parse_range for >x.y pattern Feb 18, 2024
@kt3k kt3k merged commit 24abc64 into denoland:main Feb 18, 2024
12 checks passed
kt3k added a commit to kt3k/deno_std that referenced this pull request Feb 18, 2024
kt3k added a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants