Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(internal): remove warnOnDeprecatedApi() and internal folder #4359

Merged
merged 2 commits into from
Feb 20, 2024
Merged

chore(internal): remove warnOnDeprecatedApi() and internal folder #4359

merged 2 commits into from
Feb 20, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Feb 20, 2024

It looks like we will not be using this function anytime in the future.

@iuioiua iuioiua requested a review from kt3k as a code owner February 20, 2024 07:15
kt3k
kt3k approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

BTW I think internal module could be useful for deduplicating shared private utils such as assert/_diff.ts and expect/_diff.ts

@iuioiua
Copy link
Contributor Author

iuioiua commented Feb 20, 2024

Yep, I can do in a follow up PR.

@iuioiua iuioiua merged commit ece94b6 into main Feb 20, 2024
10 checks passed
@iuioiua iuioiua deleted the remove-warnOnDeprecatedApi branch February 20, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iuioiua @kt3k